Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove layout polyfill 🎉 #17

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Remove layout polyfill 🎉 #17

merged 1 commit into from
Jun 16, 2020

Conversation

CAD97
Copy link
Owner

@CAD97 CAD97 commented Apr 30, 2020

The polyfilled methods are stable in 1.44.

This PR can be merged once 1.44 is stable on 2020-06-04.

@CAD97
Copy link
Owner Author

CAD97 commented Jun 16, 2020

bors: r+

@bors
Copy link
Contributor

bors bot commented Jun 16, 2020

Merge conflict.

@CAD97
Copy link
Owner Author

CAD97 commented Jun 16, 2020

bors: r+

bors bot added a commit that referenced this pull request Jun 16, 2020
17: Remove layout polyfill 🎉 r=CAD97 a=CAD97

The polyfilled methods are [stable in 1.44](https://doc.rust-lang.org/beta/std/alloc/struct.Layout.html#method.extend).

This PR can be merged once 1.44 is stable [on 2020-06-04](https://www.whatrustisit.com/).

Co-authored-by: CAD97 <[email protected]>
Co-authored-by: Christopher Durham <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 16, 2020

Build failed:

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files           8        8           
  Lines         561      561           
=======================================
  Hits          438      438           
  Misses        123      123           
Impacted Files Coverage Δ
src/green/node.rs 92.45% <ø> (ø)
src/green/token.rs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39fe7d...d696641. Read the comment docs.

@CAD97 CAD97 force-pushed the layout-polyfill branch from d9390a6 to d696641 Compare June 16, 2020 23:30
@CAD97
Copy link
Owner Author

CAD97 commented Jun 16, 2020

bors: r+

@bors
Copy link
Contributor

bors bot commented Jun 16, 2020

Build succeeded:

@bors bors bot merged commit b775c1f into master Jun 16, 2020
@bors bors bot deleted the layout-polyfill branch June 16, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant